> On Dec 6, 2018, at 14:14, Cédric Le Goater <c...@kaod.org> wrote: > > Hello, > >> Your patch has style problems, please review. If any of these errors >> are false positives report them to the maintainer, see >> CHECKPATCH in MAINTAINERS. >> Checking PATCH 25/37: spapr/xive: add state synchronization with KVM... >> Checking PATCH 26/37: spapr/xive: introduce a VM state change handler... >> ERROR: spaces required around that '*' (ctx:WxV) >> #38: FILE: hw/intc/spapr_xive_kvm.c:341: >> + static void kvmppc_xive_sync_all(sPAPRXive *xive, Error **errp) >> ^ >> >> total: 1 errors, 0 warnings, 135 lines checked > > This looks like a false positive. Right. Without looking at the checkpatch code, I suspect this is due to sPAPRXive starts with a lower case letter which is not standard. Fam > > C. >
- [Qemu-devel] [PATCH v6 24/37] spapr/xive: add KVM suppor... Cédric Le Goater
- [Qemu-devel] [PATCH v6 33/37] spapr/rtas: modify spapr_r... Cédric Le Goater
- [Qemu-devel] [PATCH v6 29/37] spapr: set the interrupt p... Cédric Le Goater
- [Qemu-devel] [PATCH v6 37/37] spapr: add KVM support to ... Cédric Le Goater
- [Qemu-devel] [PATCH v6 35/37] spapr: introduce routines ... Cédric Le Goater
- [Qemu-devel] [PATCH v6 32/37] ppc/xics: introduce a icp_... Cédric Le Goater
- [Qemu-devel] [PATCH v6 34/37] sysbus: add a sysbus_mmio_... Cédric Le Goater
- [Qemu-devel] [PATCH v6 36/37] spapr: check for KVM IRQ d... Cédric Le Goater
- Re: [Qemu-devel] [PATCH v6 00/37] ppc: support for the X... no-reply
- Re: [Qemu-devel] [PATCH v6 00/37] ppc: support for ... Cédric Le Goater
- Re: [Qemu-devel] [PATCH v6 00/37] ppc: support ... Fam Zheng