On 12/6/18 10:49 AM, Thomas Huth wrote:
The test does not use any of the functions that require global_qtest,
so we can simply get rid of this global variable here.

Signed-off-by: Thomas Huth <th...@redhat.com>
---
  tests/boot-serial-test.c | 13 +++++++------
  1 file changed, 7 insertions(+), 6 deletions(-)


-    global_qtest = qtest_initf("%s %s -M %s,accel=tcg:kvm "
-                               "-chardev file,id=serial0,path=%s "
-                               "-no-shutdown -serial chardev:serial0 %s",
-                               codeparam, code ? codetmp : "",
-                               test->machine, serialtmp, test->extra);
+    qts = qtest_initf("%s %s -M %s,accel=tcg:kvm -no-shutdown "
+                      "-chardev file,id=serial0,path=%s "
+                      " -serial chardev:serial0 %s",

What happened to -no-shutdown?

+                      codeparam, code ? codetmp : "", test->machine,
+                      serialtmp, test->extra);
      if (code) {
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Reply via email to