Hi Paolo, On 12/3/18 4:32 PM, Paolo Bonzini wrote: > Patches 1-14 are actually a refactoring of vhost and vhost-user-test so > that it can be "qtested" on all targets that support virtio-net. > > Patches 15-18 are other small refactorings to the libqos library and fixes > to the Makefile. > > Patch 19 is the framework, including unit tests, while the rest is conversions > of existing tests. We tried to pick tests that used a mix of features of > qtest, and that cover as many use cases as possible within qgraph. > In particular: > > - sdhci-test was the motivating example for the duplication between > PCI and MMIO versions of the same devices, so it come first > > - all virtio tests were converted, since they also have both MMIO and > PCI variants and they taught us a lot about modeling devices within > qgraph > > - all PCI devices that had "nop" tests only were converted, so that they > can avoid defining their copy of the test, and can instead use a > common test > > - finally, three more PCI devices were converted as an example - e1000e, > nvme and megasas > > This submission includes quite a few changes and cleanups that we did > not manage to complete before Emanuele restarted classes, but this > is almost entirely his baby; don't be fooled by the number of patches > authored by him vs. myself. I have noted my changes to the framework > in the commit message to patch 19, to help people that followed the > previous submissions; apart from that my changes consist of porting > vhost-user-test and turning the nop tests into generic PCI and virtio > tests (even though Emanuele had done the conversion to qgraph, he had > left the tests in the nodes due to lack of time).
I'v tested the series and am quite happy with it. I did not notice anything particular that could block it. I'll send some comments in few patches that often apply to various patches. Series: Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> Regards, Phil.
