On Fri, Mar 11, 2011 at 10:31:31PM +0000, Peter Maydell wrote: > On 11 March 2011 18:30, Nathan Froyd <froy...@codesourcery.com> wrote: > > Is there a reason that you don't simply use the global env rather than > > passing in an extra parameter everywhere? > > Just following the pattern that generally seems to be used by > most helper functions, ie if you want the CPU env pass it in > as a parameter. As far as I know, you can't use the global > env unless you're in op_helper.c because that's the only > source file compiled with the right flags.
Oh, right. I am ambivalent as to whether passing env to such functions is the right thing to do or not. > > I wonder if it'd be worthwhile just to merge these functions into > > op_helper.c, since we have a proper FP status for NEON bits now. > > Why move these and not (for instance) the VFP helpers > in helper.c which use the CPU env for more or less the > same reasons? No reason, other than that I wasn't thinking about the VFP helpers. :) -Nathan
