On Sat, 2018-12-22 at 10:13 +0100, Paolo Bonzini wrote: > On 22/12/18 02:01, Robert Hoo wrote: > > On Fri, 2018-12-21 at 16:27 +0100, Paolo Bonzini wrote: > > > On 21/12/18 16:22, Philippe Mathieu-Daudé wrote: > > > > Hi Paolo, > > > > > > > > On 12/21/18 7:30 AM, Paolo Bonzini wrote: > > > > > From: Robert Hoo <robert...@linux.intel.com> > > > > > > > > > > Processor tracing is not yet implemented for KVM and it will > > > > > be > > > > > an > > > > > opt in feature requiring a special module parameter. > > > > > Disable it, because it is wrong to enable it by default and > > > > > it is impossible that no one has ever used it. > > > > > > > > > > Cc: qemu-sta...@nongnu.org > > > > > > > > Does this patch misses Robert S-o-b? > > > > Signed-off-by: Robert Hoo <robert...@linux.intel.com> > > > > Paolo's right. It didn't come from me. > > > > > > No, the author is wrong, it should be me. "git commit -c" > > > apparently > > > copies the author from the original commit. > > > > > > Paolo > > > > Hi Paolo, would you hold on INTEL_PT removal for a moment? I think > > I > > need Luwei's double confirm. > > I'm aware of Luwei's patches, they will be in 4.21. As mentioned in > the > commit message, they will be an opt-in feature, not enabled by > default; > the default is system-wide tracing and no INTEL_PT CPUID bit > available > in the guest. > OK, synced with Luwei, agree with you.
> Paolo