On Wed, Jan 09, 2019 at 01:23:01PM +0000, Richard W.M. Jones wrote: > How about this one? Add a generic osdep function for reinitializing > optind, which does optreset on FreeBSD (but is identical on all other > OSes). Use it from qemu-io and qemu-img. > > I have tested this on Linux, FreeBSD and OpenBSD. > > checkpatch complains: > > WARNING: Block comments use a leading /* on a separate line > #69: FILE: include/qemu/osdep.h:591: > +/**
I think it just doesn't like your '/**' and wants '/*' instead. > WARNING: architecture specific defines should be avoided > #78: FILE: include/qemu/osdep.h:600: > +#ifdef __FreeBSD__ Normally we'd suggest doing a configure test to for the platform feature and then using a feature based ifdef test. In this case though that would be difficult and/or overly complex. This does make me wonder about the other *BSDs, OS-X and Mingw though ? Should they all be using the #else codepath, or should the other BSDs / OS-X use the __FreeBSD__ codepath. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
