> It seems, that this approach is not always correct. > Now timerlist_deadline_ns uses all virtual timers for deadline calculation > (including external > ones). > qemu_start_warp_timer uses the deadline for setting warp timer (which should > be deterministic). > Therefore warp timer may become non-deterministic and replay may behave > differently compared to > recording phase. > > We have to rollback these or improve somehow to avoid non-determinism.
I dont understand how this approach would even introduce non-determinism. I'm not sure about aspects of timers subsystem you mentioned, assuming that maybe we missed something when tried to optimize. But this has nothing to do with determinism as long as we treat all virtual clock timers as deterministic, regardless of EXTERNAL attribute being set or not. They are intended to be used as such by design, aren't? This attribute was introduced purely to avoid extra events in log. Artem
