Vitaly Kuznetsov <vkuzn...@redhat.com> writes: > Eduardo Habkost <ehabk...@redhat.com> writes: > >> On Wed, Dec 19, 2018 at 06:25:06PM +0100, Vitaly Kuznetsov wrote: >>> Eduardo Habkost <ehabk...@redhat.com> writes: >>> >>> > On Mon, Dec 03, 2018 at 03:17:06PM +0100, Vitaly Kuznetsov wrote: >>> >> Eduardo Habkost <ehabk...@redhat.com> writes: >>> > [...] >>> >> > But note that we might still be able to move the existing >>> >> > "hyperv_*" features to feature_word_info[].feat_names. We just >>> >> > need to keep the same semantics (e.g. enable >>> >> > HV_HYPERCALL_AVAILABLE automatically when some features are set). >>> >> > >>> >> > Maybe we can make some of the feature properties read-only. This >>> >> > way we can give them meaningful names for debugging and error >>> >> > messages, even if we don't want to make them configurable >>> >> > directly. >>> >> >>> >> I'd suggest (if there are no objections of course) we do this separately >>> >> from this patch. [...] >>> > >>> > Agreed. >>> > >>> >>> Paolo, Eduardo, >>> >>> in case there are no concerns here, could you please pick this patch up? >>> Thanks! >> >> Queued, thanks! >> >> Can you please send the comment you wrote about feat_names as a >> follow-up patch? > > Oops, sorry, I just realized I promissed to send out v2 with it and > aparently never did. Will send out a follow-up patch shortly. Thanks!
Hey Eduardo, any news about the fate of this patch? (Correcting myself: there was v2 with the comment included: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg00355.html but as I sent the follow-up patch you requested separately too: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg05463.html ) -- Vitaly