On 1/14/19 1:35 PM, Gerd Hoffmann wrote: > On Mon, Jan 14, 2019 at 11:24:14AM +0100, Philippe Mathieu-Daudé wrote: >> On 1/11/19 6:32 PM, Paolo Bonzini wrote: >>> On 11/01/19 15:08, Philippe Mathieu-Daudé wrote: >>>> PixelFormat is used by "ui/console.h" and by "ui/qemu-pixman.h". >>> >>> ui/console.h already includes ui/qemu-pixman.h, just move it there? >> >> That was my first though but then noticed pixman seems a bit >> different/unrelated. If Gerd is OK I will do it. (I should have written >> that in the commit). > > console depends on pixman anyway, so that move would be fine.
Good. > > BTW: Should not be that hard to remove PixelFormat altogether, or move > the bits which are still needed to vnc which is the only user left > (beside deprecated sdl1 which should go away soon). I can help there once SDL1 got removed. Thanks, Phil.