On Thu, 10 Jan 2019 14:00:07 +0100
Pierre Morel <pmo...@linux.ibm.com> wrote:
> The size of the accessible iommu memory region in the guest
> is given to the IOMMU by the guest through the mpcifc request
> specifying the PCI Base Address and the PCI Address Limit.
>
> Let set the size of the IOMMU region to:
s/Let/Let's/
> (PCI Address Limit) - (PCI Base Address) + 1.
>
> Signed-off-by: Pierre Morel <pmo...@linux.ibm.com>
> ---
> hw/s390x/s390-pci-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> index 69e0671..e97696a 100644
> --- a/hw/s390x/s390-pci-bus.c
> +++ b/hw/s390x/s390-pci-bus.c
> @@ -660,7 +660,7 @@ void s390_pci_iommu_enable(S390PCIIOMMU *iommu)
> char *name = g_strdup_printf("iommu-s390-%04x", iommu->pbdev->uid);
> memory_region_init_iommu(&iommu->iommu_mr, sizeof(iommu->iommu_mr),
> TYPE_S390_IOMMU_MEMORY_REGION,
> OBJECT(&iommu->mr),
> - name, iommu->pal + 1);
> + name, iommu->pal - iommu->pba + 1);
> iommu->enabled = true;
> memory_region_add_subregion(&iommu->mr, 0,
> MEMORY_REGION(&iommu->iommu_mr));
> g_free(name);
Looks good to me. Collin, can I get an ack from you so I can queue it?
