Hi Paolo,
On Wed, Jan 16, 2019 at 10:17:15PM +0100, Paolo Bonzini wrote:
> On 16/01/19 19:31, Paolo Bonzini wrote:
> >
> > I get this:
> >
> > CC optionrom/pvh_main.o
> > /tmp/ccoel69H.s: Assembler messages:
> > /tmp/ccoel69H.s:171: Error: attempt to move .org backwards
> >
> > when applying this series on CentOS 7.
>
> Oops, the issue was actaually in linux_dma - I was confused by make -j
> reordering the output. The fix is trivial
Thanks for the fix! I didn't have this error on Fedora 29 (gcc 8.2.1).
>
> --- a/pc-bios/optionrom/linuxboot_dma.c
> +++ b/pc-bios/optionrom/linuxboot_dma.c
> @@ -20,10 +20,6 @@
> * Richard W.M. Jones <rjo...@redhat.com>
> */
>
> -#include <stdint.h>
> -#include "optrom.h"
> -#include "optrom_fw_cfg.h"
> -
> asm(
> ".text\n"
> ".global _start\n"
> @@ -62,6 +58,10 @@ asm(
> " jmp load_kernel\n"
> );
>
> +#include <stdint.h>
> +#include "optrom.h"
> +#include "optrom_fw_cfg.h"
> +
> static inline void set_es(void *addr)
> {
> uint32_t seg = (uint32_t)addr >> 4;
>
>
> Also, the $? in the new rule should be $^. I wouldn't use a pattern
> rule for that, writing it explicitly as "pvh.img: pvh.S pvh_main.c"
I'll fix the Makefile.
Thanks,
Stefano
>
> Thanks,
>
> Paolo
