On 1/24/19 12:23 PM, Gerd Hoffmann wrote:
>> sdl)
>> if test "$sdl" = "no"; then
>> - error_exit "sdl not found or disabled, can not use sdl audio driver"
>> + echo "WARN: sdl not found or disabled, can not use sdl audio driver"
>> + audio_drv_list=$(echo "$audio_drv_list" | sed -e 's/sdl *//g')
>
> Busy tackling that in a separate patch series (audio: rework driver
> probing)
But we need the Milkymist TMU fixes to build without SDL,
I still get this error when building the series you mentioned using
--disable-sdl on OpenBSD:
LINK lm32-softmmu/qemu-system-lm32
hw/lm32/milkymist.o: In function `milkymist_tmu2_create':
hw/lm32/milkymist-hw.h:114: undefined reference to `XOpenDisplay'
hw/lm32/milkymist-hw.h:140: undefined reference to `XFree'
hw/lm32/milkymist-hw.h:141: undefined reference to `XCloseDisplay'
hw/lm32/milkymist-hw.h:130: undefined reference to `XCloseDisplay'
../hw/display/milkymist-tmu2.o: In function `tmu2_glx_init':
hw/display/milkymist-tmu2.c:112: undefined reference to `XOpenDisplay'
hw/display/milkymist-tmu2.c:123: undefined reference to `XFree'
collect2: error: ld returned 1 exit status
gmake[1]: *** [Makefile:199: qemu-system-lm32] Error 1
>
>> fi
>> ;;
>>
>> @@ -3408,6 +3409,9 @@ for drv in $audio_drv_list; do
>> ;;
>> esac
>> done
>> +if test -z "$audio_drv_list"; then
>> + audio_drv_list="none"
>> +fi
>
> Not needed, "none" is used as fallback even without this.
It is not needed indeed, but I find it clearer when looking at the
./configure output, rather than having an empty list:
SDL support no
Audio drivers
GEN config-host.h
vs:
SDL support no
Audio drivers none
GEN config-host.h
Maybe my error was to not clarify that this change is purely cosmetic.
Your call anyway.
>
> The other tree patches look fine to me, I'll go queue them up.
Thanks! I'll wait for Michael Walle feedbacks before respining rebased
on your work, also fixing "WARN".
>
> cheers,
> Gerd
>
