On 1/28/19 11:03 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" <dgilb...@redhat.com> > > Add a qmp command that can trigger guest announcements. > > It uses it's own announce-timer instance, and parameters
s/it's/its/ (here, you want the possessive form without apostrophe; the
contraction form is correct only when you can use "it is" in the same place)
> passed to it explicitly in the command.
>
> Like most qmp commands, it's in the main thread/bql, so
Here, "it's" is correct.
> there's no racing with any outstanding timer.
>
> Based on work of Germano Veit Michel <germ...@redhat.com> and
> Vladislav Yasevich <vyase...@redhat.com>
>
> Signed-off-by: Dr. David Alan Gilbert <dgilb...@redhat.com>
> ---
> net/announce.c | 8 ++++++++
> qapi/net.json | 20 ++++++++++++++++++++
> 2 files changed, 28 insertions(+)
>
> +++ b/qapi/net.json
> @@ -707,3 +707,23 @@
> 'max': 'int',
> 'rounds': 'int',
> 'step': 'int' } }
> +
> +##
> +# @announce-self:
> +#
> +# Trigger generation of broadcast RARP frames to update network switches.
> +# This can be useful when network bonds fail-over the active slave.
> +#
> +# @params: AnnounceParameters giving timing and repetition count of announce
> +#
> +# Example:
> +#
> +# -> { "execute": "announce-self"
> +# "arguments": { "initial": 50, "max": 550, "rounds": 10, "step": 50 } }
Again, can any of these have useful defaults to be left optional?
> +# <- { "return": {} }
> +#
> +# Since: 4.0
> +##
> +{ 'command': 'announce-self',
> + 'data' : {'params': 'AnnounceParameters'} }
> +
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
