On Tue, Mar 22, 2011 at 03:25:11PM +0000, Stefan Hajnoczi wrote: > On Mon, Mar 21, 2011 at 10:07 PM, Alon Levy <al...@redhat.com> wrote: > > +# check for libcacard for smartcard support > > +if test "$smartcard" != "no" ; then > > + smartcard="yes" > > + smartcard_cflags="" > > + # TODO - what's the minimal nss version we support? > > + if test "$smartcard_nss" != "no"; then > > + if $pkg_config --atleast-version=3.12.8 nss >/dev/null 2>&1 ; then > > + smartcard_nss="yes" > > + smartcard_cflags="-I\$(SRC_PATH)/libcacard" > > + libcacard_libs=$($pkg_config --libs nss 2>/dev/null) > > + libcacard_cflags=$($pkg_config --cflags nss 2>/dev/null) > > + QEMU_CFLAGS="$QEMU_CFLAGS $smartcard_cflags $libcacard_cflags" > > + LIBS="$libcacard_libs $LIBS" > > + else > > + if test "$smartcard_nss" == "yes"; then > > + feature_not_found "nss" > > + fi > > + smartcard_nss="no" > > + fi > > + fi > > +fi > > +if test "$smartcard" == "no" ; then > > + smartcard_nss="no" > > +fi > > '==' is not portable, please use '=': > > $ test x == y > test: 1: x: unexpected operator > > I noticed that this patch introduces error messages here when I run > ./configure. > ok, will fix.
> > +if [ $source_path != `pwd` ]; then > > + # out of tree build > > + mkdir -p libcacard > > + rm -f libcacard/Makefile > > + ln -s $source_path/libcacard/Makefile libcacard/Makefile > > +fi > > $source_path should have double-quotes around it so this works even > when the path has spaces. > ok, will fix. > Stefan
