On 2019-02-03 23:07, Philippe Mathieu-Daudé wrote: > The Loongson 2E uses a Bonito64 system controller as North Bridge and a > VT82C686 chipset as South Bridge. The network card chipset is a RTL8139D. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- [...] > diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig > index 2940ff39ab..16b2bdb068 100644 > --- a/hw/mips/Kconfig > +++ b/hw/mips/Kconfig > @@ -42,6 +42,11 @@ config JAZZ > > config FULONG > bool > + select PCI_BONITO > + select VT82C686 > + select SMBUS_EEPROM > + select RTL8139_PCI
If I've got the code right, the RTL8139 is optional for this board, i.e. when you run with -nodefaults or -net none, then the board is still usable. So this is not a hard requirement and thus I think it would be nicer to drop the "select RTL8139_PCI" and rely on the "default y if PCI_DEVICES" in the hw/net/Kconfig file. Thomas
