On Tue, Feb 05, 2019 at 04:09:24PM +0000, Alex Bennée wrote: > > Philippe Mathieu-Daudé <phi...@redhat.com> writes: > > > Various iotests scripts (run via 'make check-block') use bash > > specific extentions. OpenBSD comes with the Korn shell as default. > > Install bash to be able to run those tests. > > Hmmm given we use plain POSIX shell for configure portability is there a > reason the check-block test scripts use bash? I guess it doesn't get > picked up as check-block isn't run normally.
configure requests any POSIX shell (#!/bin/sh) & aim for portability. The block iotests though made an explicit choice not to care for POSIX shell portability and so explicitly request bash (#!/bin/bash). The block iotests are not something we expect every user of QEMU to run, so it is valid to have a more specific requirement for executing them, than is required by configure for general purpose build + unit tests. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
