On Mon, 11 Feb 2019 12:57:36 -0500 "Jason J. Herne" <jjhe...@linux.ibm.com> wrote:
> On 2/4/19 5:45 AM, Cornelia Huck wrote: > > On Tue, 29 Jan 2019 08:29:12 -0500 > > "Jason J. Herne" <jjhe...@linux.ibm.com> wrote: > >> diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c > >> index 7e3f65e..2457752 100644 > >> --- a/pc-bios/s390-ccw/main.c > >> +++ b/pc-bios/s390-ccw/main.c > >> @@ -55,17 +55,18 @@ unsigned int get_loadparm_index(void) > >> * NOTE: The global variable blk_schid is updated to contain the > >> subchannel > >> * information. > >> */ > >> -static bool find_dev(Schib *schib, int dev_no) > >> +static bool find_subch(int dev_no) > > > > I'm wondering why you drop passing in the schib here? But OTOH, the > > usage of global variables or not is a bit confused in the bios anyway... > > > > I dropped it as an argument because the schib was never used outside of > find_dev. Seems to > make sense to make it a local variable in this case. > Fair enough.
