On 2/12/19 2:27 PM, Eric Blake wrote:
> On 2/11/19 7:02 PM, John Snow wrote:
>> These mean the same thing now. Unify them and rename the merged call
>> bdrv_dirty_bitmap_busy to indicate semantically what we are describing,
>> as well as help disambiguate from the various _locked and _unlocked
>> versions of bitmap helpers that refer to mutex locks.
>
> Yay, definitely improved naming.
>
Glad you agree! Thanks to Vladimir for the suggestion.
>> ---
>> block/dirty-bitmap.c | 41 +++++++++++++++-------------------
>> blockdev.c | 18 +++++++--------
>> include/block/dirty-bitmap.h | 5 ++---
>> migration/block-dirty-bitmap.c | 6 ++---
>> nbd/server.c | 6 ++---
>> 5 files changed, 35 insertions(+), 41 deletions(-)
>>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
>
Thanks again! I'll send a V2 with a few peeks and pokes of additional
test coverage and the deprecated texi update.
--js