Patchew URL: https://patchew.org/QEMU/20190212045721.28041-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/24] target/hppa patch queue Type: series Message-id: 20190212045721.28041-1-richard.hender...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1550029560-30530-1-git-send-email-san...@codesourcery.com -> patchew/1550029560-30530-1-git-send-email-san...@codesourcery.com * [new tag] patchew/20190211170136.18680-1-richard.hender...@linaro.org -> patchew/20190211170136.18680-1-richard.hender...@linaro.org t [tag update] patchew/20190212025241.5330-1-stefa...@redhat.com -> patchew/20190212025241.5330-1-stefa...@redhat.com * [new tag] patchew/20190212045721.28041-1-richard.hender...@linaro.org -> patchew/20190212045721.28041-1-richard.hender...@linaro.org t [tag update] patchew/20190212145722.31891-1-phi...@redhat.com -> patchew/20190212145722.31891-1-phi...@redhat.com Switched to a new branch 'test' b5c5dfdaab hw/hppa: forward requests to CPU HPA a48430e571 target/hppa: fix dcor instruction b2d7de36d5 target/hppa: Fix addition '</<=' conditions 17311c79d0 target/hppa: Rearrange log conditions ae9e01783f target/hppa: move GETPC to HELPER() functions 3b8707f153 target/hppa: Merge translate_one into hppa_tr_translate_insn 20fbaff776 target/hppa: Convert fp operate insns 4ca5b0d631 target/hppa: Convert fp fused multiply-add insns d6841b65b3 target/hppa: Convert halt/reset insns d9a029560f target/hppa: Convert fp indexed memory insns 55f466ba55 target/hppa: Convert offset memory insns af0da59913 target/hppa: Convert arithmetic immediate insns 1df30dbecf target/hppa: Convert direct and indirect branches 758773e229 target/hppa: Convert shift, extract, deposit insns 612ad6b258 target/hppa: Convert conditional branches d2cdb6e898 target/hppa: Convert fp multiply-add ee9ae782f0 target/hppa: Convert indexed memory insns 0848256b5d target/hppa: Convert arithmetic/logical insns 76a314ee8a target/hppa: Convert memory management insns 0883ff944e target/hppa: Unify specializations of OR 7a5fb6d9b7 target/hppa: Convert remainder of system insns 1786cd8d4e target/hppa: Convert move to/from system registers cd64b4ccf9 target/hppa: Begin using scripts/decodetree.py 568947bacd target/hppa: Use DisasContextBase.is_jmp === OUTPUT BEGIN === 1/24 Checking commit 568947bacdff (target/hppa: Use DisasContextBase.is_jmp) 2/24 Checking commit cd64b4ccf907 (target/hppa: Begin using scripts/decodetree.py) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 WARNING: Block comments use a trailing */ on a separate line #80: FILE: target/hppa/translate.c:668: + it may be tail-called from a translate function. */ total: 0 errors, 2 warnings, 101 lines checked Patch 2/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/24 Checking commit 1786cd8d4e2b (target/hppa: Convert move to/from system registers) 4/24 Checking commit 7a5fb6d9b7eb (target/hppa: Convert remainder of system insns) 5/24 Checking commit 0883ff944ef7 (target/hppa: Unify specializations of OR) WARNING: Block comments use a leading /* on a separate line #56: FILE: target/hppa/translate.c:2650: + /* These are QEMU extensions and are nops in the real architecture: WARNING: Block comments use a leading /* on a separate line #65: FILE: target/hppa/translate.c:2659: + /* No need to check for supervisor, as userland can only pause WARNING: Block comments use * on subsequent lines #66: FILE: target/hppa/translate.c:2660: + /* No need to check for supervisor, as userland can only pause + until the next timer interrupt. */ WARNING: Block comments use a trailing */ on a separate line #66: FILE: target/hppa/translate.c:2660: + until the next timer interrupt. */ total: 0 errors, 4 warnings, 128 lines checked Patch 5/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/24 Checking commit 76a314ee8ad5 (target/hppa: Convert memory management insns) 7/24 Checking commit 0848256b5d0b (target/hppa: Convert arithmetic/logical insns) 8/24 Checking commit ee9ae782f0e4 (target/hppa: Convert indexed memory insns) WARNING: Block comments use a leading /* on a separate line #59: FILE: target/hppa/translate.c:299: +/* Convert the M:A bits within a memory insn to the tri-state value WARNING: Block comments use * on subsequent lines #60: FILE: target/hppa/translate.c:300: +/* Convert the M:A bits within a memory insn to the tri-state value + we use for the final M. */ WARNING: Block comments use a trailing */ on a separate line #60: FILE: target/hppa/translate.c:300: + we use for the final M. */ total: 0 errors, 3 warnings, 305 lines checked Patch 8/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/24 Checking commit d2cdb6e8983d (target/hppa: Convert fp multiply-add) 10/24 Checking commit 612ad6b25869 (target/hppa: Convert conditional branches) 11/24 Checking commit 758773e22930 (target/hppa: Convert shift, extract, deposit insns) 12/24 Checking commit 1df30dbecfa7 (target/hppa: Convert direct and indirect branches) 13/24 Checking commit af0da59913e5 (target/hppa: Convert arithmetic immediate insns) 14/24 Checking commit 55f466ba5585 (target/hppa: Convert offset memory insns) 15/24 Checking commit d9a029560fc8 (target/hppa: Convert fp indexed memory insns) 16/24 Checking commit d6841b65b327 (target/hppa: Convert halt/reset insns) 17/24 Checking commit 4ca5b0d63107 (target/hppa: Convert fp fused multiply-add insns) 18/24 Checking commit 20fbaff77686 (target/hppa: Convert fp operate insns) 19/24 Checking commit 3b8707f153aa (target/hppa: Merge translate_one into hppa_tr_translate_insn) 20/24 Checking commit ae9e01783f8e (target/hppa: move GETPC to HELPER() functions) 21/24 Checking commit 17311c79d00f (target/hppa: Rearrange log conditions) 22/24 Checking commit b2d7de36d5ec (target/hppa: Fix addition '</<=' conditions) ERROR: space prohibited between function name and open parenthesis '(' #25: FILE: target/hppa/translate.c:457: + assert (c != TCG_COND_NEVER && c != TCG_COND_ALWAYS); total: 1 errors, 0 warnings, 186 lines checked Patch 22/24 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 23/24 Checking commit a48430e5710f (target/hppa: fix dcor instruction) 24/24 Checking commit b5c5dfdaab59 (hw/hppa: forward requests to CPU HPA) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190212045721.28041-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
