Patchew URL: https://patchew.org/QEMU/20190213155414.22285-1-pal...@sifive.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190213155414.22285-1-pal...@sifive.com Subject: [Qemu-devel] [PATCH v7 00/35] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190213103519.32585-1-coh...@redhat.com -> patchew/20190213103519.32585-1-coh...@redhat.com t [tag update] patchew/20190213155414.22285-1-pal...@sifive.com -> patchew/20190213155414.22285-1-pal...@sifive.com * [new tag] patchew/20190215133005.15955-1-da...@redhat.com -> patchew/20190215133005.15955-1-da...@redhat.com Switched to a new branch 'test' cf8af1b029 target/riscv: Remaining rvc insn reuse 32 bit translators 0b6387f173 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 f1b7137760 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 7255005fc3 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 29f833793b target/riscv: Convert @cs_2 insns to share translation functions d113ec269f target/riscv: Remove decode_RV32_64G() 15aa79ab36 target/riscv: Remove gen_system() e4ccd14332 target/riscv: Rename trans_arith to gen_arith 6388949a32 target/riscv: Remove manual decoding of RV32/64M insn 78099fcedd target/riscv: Remove shift and slt insn manual decoding 342f63d3e9 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 39904ddf17 target/riscv: Move gen_arith_imm() decoding into trans_* functions fbf05a5809 target/riscv: Remove manual decoding from gen_store() 29ef6bb97f target/riscv: Remove manual decoding from gen_load() 540058e656 target/riscv: Remove manual decoding from gen_branch() 0422bbafd7 target/riscv: Remove gen_jalr() c82bbaced6 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 29952fcaf7 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 7766855a03 target/riscv: Convert quadrant 0 of RVXC insns to decodetree b663f9ba3d target/riscv: Convert RV priv insns to decodetree e1d0e2333d target/riscv: Convert RV64D insns to decodetree 11e36fa462 target/riscv: Convert RV32D insns to decodetree 7b63ef088b target/riscv: Convert RV64F insns to decodetree 8b820df832 target/riscv: Convert RV32F insns to decodetree 7573de5975 target/riscv: Convert RV64A insns to decodetree 837716c6f2 target/riscv: Convert RV32A insns to decodetree fae0ce83bc target/riscv: Convert RVXM insns to decodetree af0dfe7ffa target/riscv: Convert RVXI csr insns to decodetree 7053e564e9 target/riscv: Convert RVXI fence insns to decodetree 7e42764032 target/riscv: Convert RVXI arithmetic insns to decodetree 0b37b33fc9 target/riscv: Convert RV64I load/store insns to decodetree ff2422c615 target/riscv: Convert RV32I load/store insns to decodetree 49355e5f61 target/riscv: Convert RVXI branch insns to decodetree 54db7873fc target/riscv: Activate decodetree and implemnt LUI & AUIPC cdeadb1053 target/riscv: Move CPURISCVState pointer to DisasContext === OUTPUT BEGIN === 1/35 Checking commit cdeadb1053e9 (target/riscv: Move CPURISCVState pointer to DisasContext) 2/35 Checking commit 54db7873fc92 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1885: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit 49355e5f6174 (target/riscv: Convert RVXI branch insns to decodetree) 4/35 Checking commit ff2422c61576 (target/riscv: Convert RV32I load/store insns to decodetree) 5/35 Checking commit 0b37b33fc9fe (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit 7e42764032d5 (target/riscv: Convert RVXI arithmetic insns to decodetree) 7/35 Checking commit 7053e564e9a3 (target/riscv: Convert RVXI fence insns to decodetree) 8/35 Checking commit af0dfe7ffafb (target/riscv: Convert RVXI csr insns to decodetree) 9/35 Checking commit fae0ce83bcbf (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 145 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit 837716c6f294 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 188 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit 7573de59750d (target/riscv: Convert RV64A insns to decodetree) 12/35 Checking commit 8b820df8329d (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 416 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit 7b63ef088ba6 (target/riscv: Convert RV64F insns to decodetree) 14/35 Checking commit 11e36fa462e5 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 373 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit e1d0e2333dd2 (target/riscv: Convert RV64D insns to decodetree) 16/35 Checking commit b663f9ba3d4f (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit 7766855a03fd (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #246: FILE: target/riscv/translate.c:1067: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 227 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit 29952fcaf721 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 19/35 Checking commit c82bbaced646 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 20/35 Checking commit 0422bbafd73f (target/riscv: Remove gen_jalr()) 21/35 Checking commit 540058e656a4 (target/riscv: Remove manual decoding from gen_branch()) 22/35 Checking commit 29ef6bb97f00 (target/riscv: Remove manual decoding from gen_load()) 23/35 Checking commit fbf05a580992 (target/riscv: Remove manual decoding from gen_store()) 24/35 Checking commit 39904ddf1719 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 25/35 Checking commit 342f63d3e937 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 26/35 Checking commit 78099fcedd02 (target/riscv: Remove shift and slt insn manual decoding) 27/35 Checking commit 6388949a324d (target/riscv: Remove manual decoding of RV32/64M insn) 28/35 Checking commit e4ccd1433265 (target/riscv: Rename trans_arith to gen_arith) 29/35 Checking commit 15aa79ab365b (target/riscv: Remove gen_system()) 30/35 Checking commit d113ec269f7e (target/riscv: Remove decode_RV32_64G()) 31/35 Checking commit 29f833793b91 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:543: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit 7255005fc359 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 33/35 Checking commit f1b7137760c4 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit 0b6387f173e5 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 35/35 Checking commit cf8af1b029c4 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190213155414.22285-1-pal...@sifive.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
