On Mon, 18 Feb 2019 10:21:59 +0100 David Hildenbrand <da...@redhat.com> wrote:
> The issue with testing asynchronous unplug requests it that they usually > require a running guest to handle the request. However, to test if > unplug of PCI devices works, we can apply a nice little trick on some > architectures: > > On system reset, x86 ACPI, s390x and spapr will perform the unplug, > resulting in the device of interest to get deleted and a DEVICE_DELETED > event getting sent. > > On s390x, we still get a warning > qemu-system-s390x: -device virtio-mouse-pci,id=dev0: > warning: Plugging a PCI/zPCI device without the 'zpci' CPU feature > enabled; the guest will not be able to see/use this device > > This will be fixed soon, when we enable the zpci CPU feature always > (Conny already has a patch for this queued). Let's see which series makes it into mainline first ;) > > Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > Reviewed-by: Greg Kurz <gr...@kaod.org> > Reviewed-by: Thomas Huth <th...@redhat.com> > Reviewed-by: Collin Walling <wall...@linux.ibm.com> > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > tests/Makefile.include | 4 ++ > tests/device-plug-test.c | 93 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 97 insertions(+) > create mode 100644 tests/device-plug-test.c Looks sane at a glance. Acked-by: Cornelia Huck <coh...@redhat.com>
