Alex Bennée posted this patch to address an XXX comment in pflash_cfi01_realize() the other day:
Subject: [PATCH v2] hw/block: report when pflash backing file isn't aligned Message-Id: <20190215122808.22301-1-alex.ben...@linaro.org> https://lists.nongnu.org/archive/html/qemu-devel/2019-02/msg04166.html Review led me to look into its callers. Most of them are pleasantly boring: they create flash memory of some fixed size at some fixed address. A few are more creative, and some of the creative ones look quite broken to me. Fix them, and clean up some along the way. Markus Armbruster (10): pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02 pflash: Macro PFLASH_BUG() is used just once, expand hw: Use CFI_PFLASH0{1,2} and TYPE_CFI_PFLASH0{1,2} sam460ex: Don't size flash memory to match backing image ppc405_boards: Don't size flash memory to match backing image r2d: Flash memory creation is confused about size, mark FIXME mips_malta: Clean up definition of flash memory size somewhat pflash: Clean up after commit 368a354f02b part 1 pflash: Clean up after commit 368a354f02b part 2 hw/arm hw/xtensa: De-duplicate pflash creation code some hw/arm/collie.c | 9 +- hw/arm/digic_boards.c | 3 +- hw/arm/gumstix.c | 8 +- hw/arm/mainstone.c | 4 +- hw/arm/musicpal.c | 8 +- hw/arm/omap_sx1.c | 8 +- hw/arm/versatilepb.c | 3 +- hw/arm/vexpress.c | 30 ++---- hw/arm/virt.c | 27 ++--- hw/arm/xilinx_zynq.c | 5 +- hw/arm/z2.c | 5 +- hw/block/pflash_cfi01.c | 120 ++++++++++++----------- hw/block/pflash_cfi02.c | 69 ++++++------- hw/i386/pc_sysfw.c | 10 +- hw/lm32/lm32_boards.c | 8 +- hw/lm32/milkymist.c | 4 +- hw/microblaze/petalogix_ml605_mmu.c | 5 +- hw/microblaze/petalogix_s3adsp1800_mmu.c | 4 +- hw/mips/mips_malta.c | 15 ++- hw/mips/mips_r4k.c | 4 +- hw/ppc/ppc405_boards.c | 59 ++++------- hw/ppc/sam460ex.c | 23 ++--- hw/ppc/virtex_ml507.c | 4 +- hw/sh4/r2d.c | 11 ++- hw/xtensa/xtfpga.c | 26 +++-- include/hw/block/flash.h | 65 +++++++----- 26 files changed, 258 insertions(+), 279 deletions(-) -- 2.17.2
