Patchew URL: https://patchew.org/QEMU/20190218125615.18970-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190218125615.18970-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190218125615.18970-1-arm...@redhat.com -> patchew/20190218125615.18970-1-arm...@redhat.com Switched to a new branch 'test' 9a994e41a5 hw/arm hw/xtensa: De-duplicate pflash creation code some 303fbacd55 pflash: Clean up after commit 368a354f02b part 2 3f16bf66bc pflash: Clean up after commit 368a354f02b part 1 3e2ae31e84 mips_malta: Clean up definition of flash memory size somewhat d0652958b7 r2d: Flash memory creation is confused about size, mark FIXME f26f2e4d2d ppc405_boards: Don't size flash memory to match backing image e5dd4a33f5 sam460ex: Don't size flash memory to match backing image 2eec664e4d hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2} 83da6876dd pflash: Macro PFLASH_BUG() is used just once, expand 0b9075ea6a pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02 === OUTPUT BEGIN === 1/10 Checking commit 0b9075ea6a77 (pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02) ERROR: space prohibited between function name and open parenthesis '(' #128: FILE: hw/block/pflash_cfi01.c:288: +static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset, ERROR: space prohibited between function name and open parenthesis '(' #340: FILE: hw/block/pflash_cfi02.c:141: +static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset, ERROR: space prohibited between function name and open parenthesis '(' #358: FILE: hw/block/pflash_cfi02.c:264: +static void pflash_write (PFlashCFI02 *pfl, hwaddr offset, total: 3 errors, 0 warnings, 483 lines checked Patch 1/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/10 Checking commit 83da6876dd88 (pflash: Macro PFLASH_BUG() is used just once, expand) 3/10 Checking commit 2eec664e4dcd (hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}) 4/10 Checking commit e5dd4a33f5aa (sam460ex: Don't size flash memory to match backing image) 5/10 Checking commit f26f2e4d2d3f (ppc405_boards: Don't size flash memory to match backing image) 6/10 Checking commit d0652958b7c8 (r2d: Flash memory creation is confused about size, mark FIXME) 7/10 Checking commit 3e2ae31e8434 (mips_malta: Clean up definition of flash memory size somewhat) 8/10 Checking commit 3f16bf66bce3 (pflash: Clean up after commit 368a354f02b part 1) ERROR: spaces required around that '-' (ctx:VxV) #90: FILE: hw/arm/musicpal.c:1639: + pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX, ^ ERROR: spaces required around that '-' (ctx:VxV) #98: FILE: hw/arm/musicpal.c:1646: + pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX, ^ total: 2 errors, 0 warnings, 248 lines checked Patch 8/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/10 Checking commit 303fbacd5529 (pflash: Clean up after commit 368a354f02b part 2) 10/10 Checking commit 9a994e41a577 (hw/arm hw/xtensa: De-duplicate pflash creation code some) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190218125615.18970-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
