On Wed, Feb 13, 2019 at 07:01:35AM +0100, Markus Armbruster wrote: > Daniel P. Berrangé <berra...@redhat.com> writes: > > > Yes, this is another regression accidentally introduced by the keyboard > > state tracker. > > > > When GTK does key repeat it omits the Up event for repeated keys. > > > > IOW, you get > > > > Press (a) > > Press (a) > > Press (a) > > Release (a) > > This is how keyboards commonly do it, if I remember correctly.
Yes, this is pretty much what the hardware sends, intentionally, so the software can figure whenever the event is a autorepeat event or not. These days most software just ignores repeated events from the hardware and generates them in software instead, to not depend on the keyboard hardware capabilities for autorepeat. > > This might affect other frontends too if they use the same trick for > > key repeat > > Plausible. UIs are not consistent here. But, yes, we probably should just allow down events even if the key is already in down state. cheers, Gerd
