On 2/19/19 7:07 AM, Wei Yang wrote: > Function acpi_memory_plug_cb() is only invoked when dev is a PCDIMM, > which is hotpluggable. This means it is not necessary to check this > property again. > > This patch removes this check. > > Signed-off-by: Wei Yang <richardw.y...@linux.intel.com> > --- > hw/acpi/memory_hotplug.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c > index 8c7c1013f3..b19673d337 100644 > --- a/hw/acpi/memory_hotplug.c > +++ b/hw/acpi/memory_hotplug.c > @@ -266,10 +266,6 @@ void acpi_memory_plug_cb(HotplugHandler *hotplug_dev, > MemHotplugState *mem_st, > MemStatus *mdev; > DeviceClass *dc = DEVICE_GET_CLASS(dev);
You have to remove the 'dc' variable now: CC hw/acpi/memory_hotplug.o hw/acpi/memory_hotplug.c: In function ‘acpi_memory_plug_cb’: hw/acpi/memory_hotplug.c:267:18: error: unused variable ‘dc’ [-Werror=unused-variable] DeviceClass *dc = DEVICE_GET_CLASS(dev); ^~ Once removed: Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com> > > - if (!dc->hotpluggable) { > - return; > - } > - > mdev = acpi_memory_slot_status(mem_st, dev, errp); > if (!mdev) { > return; >