On 2/19/19 2:31 AM, Wei Yang wrote: > All the example code are indented with four spaces except this one. > > Fix this by adding four spaces here. > > Signed-off-by: Wei Yang <richardw.y...@linux.intel.com> > --- > CODING_STYLE | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index 73f66ca185..27581d80c1 100644 > --- a/CODING_STYLE > +++ b/CODING_STYLE > @@ -134,10 +134,10 @@ block to a separate function altogether. > When comparing a variable for (in)equality with a constant, list the > constant on the right, as in: > > -if (a == 1) { > - /* Reads like: "If a equals 1" */ > - do_something(); > -} > + if (a == 1) { > + /* Reads like: "If a equals 1" */
I guess you found a bug in the documentation :) Since 8c06fbdf36bf4d the style asked is: We now require Linux-kernel-style multiline comments: /* * line one * line two */ > + do_something(); > + } > > Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. > Besides, good compilers already warn users when '==' is mis-typed as '=', >