In $SUBJECT s/main-loop/io/ On Fri, Feb 22, 2019 at 01:59:10PM +0200, Alberto Garcia wrote: > After g_source_attach() the GMainContext holds a reference to the > GSource, so the caller does not need to keep it. > > qio_task_thread_worker() is not releasing its reference so the GSource > is being leaked since a17536c594bfed94d05667b419f747b692f5fc7f. > > Signed-off-by: Alberto Garcia <be...@igalia.com> > --- > io/task.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/io/task.c b/io/task.c > index 64c4c7126a..1ae7b86488 100644 > --- a/io/task.c > +++ b/io/task.c > @@ -136,6 +136,7 @@ static gpointer qio_task_thread_worker(gpointer opaque) > qio_task_thread_result, task, NULL); > g_source_attach(task->thread->completion, > task->thread->context); > + g_source_unref(task->thread->completion); > trace_qio_task_thread_source_attach(task, task->thread->completion); > > qemu_cond_signal(&task->thread_cond);
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
