Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' ac35998b5f target/riscv: Remaining rvc insn reuse 32 bit translators fffdd9041b target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 3b2bfb2abd target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 a34d23b730 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns bb8dfd6ed7 target/riscv: Convert @cs_2 insns to share translation functions c0c61f9d8e target/riscv: Remove decode_RV32_64G() adc0f7585b target/riscv: Remove gen_system() b50e52513d target/riscv: Rename trans_arith to gen_arith 598980bf8c target/riscv: Remove manual decoding of RV32/64M insn d8796c1854 target/riscv: Remove shift and slt insn manual decoding 59c761aa98 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 7a47a3d21b target/riscv: Move gen_arith_imm() decoding into trans_* functions d15bbff7e3 target/riscv: Remove manual decoding from gen_store() 635e53014b target/riscv: Remove manual decoding from gen_load() 34d4b93fb9 target/riscv: Remove manual decoding from gen_branch() 4759cd1171 target/riscv: Remove gen_jalr() 8a6aac3a76 target/riscv: Convert quadrant 2 of RVXC insns to decodetree 1b744b6717 target/riscv: Convert quadrant 1 of RVXC insns to decodetree b61fe6010f target/riscv: Convert quadrant 0 of RVXC insns to decodetree 619ad5f255 target/riscv: Convert RV priv insns to decodetree 03d125944f target/riscv: Convert RV64D insns to decodetree da9d960928 target/riscv: Convert RV32D insns to decodetree d8611eee8f target/riscv: Convert RV64F insns to decodetree 2e3f999836 target/riscv: Convert RV32F insns to decodetree befeb7f0dd target/riscv: Convert RV64A insns to decodetree 08e313732e target/riscv: Convert RV32A insns to decodetree 3f454da12d target/riscv: Convert RVXM insns to decodetree 70ef3d6037 target/riscv: Convert RVXI csr insns to decodetree a64bd0dc62 target/riscv: Convert RVXI fence insns to decodetree 311a9ba90e target/riscv: Convert RVXI arithmetic insns to decodetree c1282a4b41 target/riscv: Convert RV64I load/store insns to decodetree 7b9ca3e6aa target/riscv: Convert RV32I load/store insns to decodetree f1f8874efb target/riscv: Convert RVXI branch insns to decodetree 05ea102cd4 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 05ea102cd4f4 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit f1f8874efb91 (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 7b9ca3e6aa9a (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit c1282a4b4113 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 311a9ba90e2e (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit a64bd0dc62b4 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 70ef3d6037ff (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit 3f454da12deb (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 08e313732e44 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit befeb7f0ddb0 (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 2e3f9998360e (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit d8611eee8f6c (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit da9d960928a2 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 03d125944f1b (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit 619ad5f255a8 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit b61fe6010f2b (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit 1b744b67176c (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 8a6aac3a76af (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit 4759cd1171fb (target/riscv: Remove gen_jalr()) 20/34 Checking commit 34d4b93fb960 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 635e53014bb2 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit d15bbff7e3a6 (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 7a47a3d21b5a (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 59c761aa9850 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit d8796c185490 (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 598980bf8c27 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit b50e52513d9c (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit adc0f7585bf0 (target/riscv: Remove gen_system()) 29/34 Checking commit c0c61f9d8e16 (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit bb8dfd6ed7b5 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit a34d23b730c9 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 3b2bfb2abda1 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit fffdd9041b4b (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit ac35998b5fba (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
