Patchew URL: https://patchew.org/QEMU/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190222141024.22217-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v8 00/34] target/riscv: Convert to decodetree Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de -> patchew/20190222141024.22217-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 13675555e5 target/riscv: Remaining rvc insn reuse 32 bit translators 115c117df9 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 994387064c target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 d13b40ed12 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 25611ad897 target/riscv: Convert @cs_2 insns to share translation functions 2589dfcbee target/riscv: Remove decode_RV32_64G() 89c15cbd76 target/riscv: Remove gen_system() ab3c0b429e target/riscv: Rename trans_arith to gen_arith 8056650f79 target/riscv: Remove manual decoding of RV32/64M insn 36fd7789f5 target/riscv: Remove shift and slt insn manual decoding 92769a48c7 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 743385aa26 target/riscv: Move gen_arith_imm() decoding into trans_* functions a9c474569f target/riscv: Remove manual decoding from gen_store() 6140efd89e target/riscv: Remove manual decoding from gen_load() 79ac650f56 target/riscv: Remove manual decoding from gen_branch() f9156ac845 target/riscv: Remove gen_jalr() 628e2ef24e target/riscv: Convert quadrant 2 of RVXC insns to decodetree acc7f50080 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 4fd1181ee3 target/riscv: Convert quadrant 0 of RVXC insns to decodetree e3a4548a0b target/riscv: Convert RV priv insns to decodetree 111ab99339 target/riscv: Convert RV64D insns to decodetree 8b1cbcfdb0 target/riscv: Convert RV32D insns to decodetree 3b814c1bc6 target/riscv: Convert RV64F insns to decodetree 8aebcb350c target/riscv: Convert RV32F insns to decodetree 83d2832ed1 target/riscv: Convert RV64A insns to decodetree 5450d8d488 target/riscv: Convert RV32A insns to decodetree abc495f861 target/riscv: Convert RVXM insns to decodetree 29c983f8f0 target/riscv: Convert RVXI csr insns to decodetree 674da1a178 target/riscv: Convert RVXI fence insns to decodetree 0b0675d537 target/riscv: Convert RVXI arithmetic insns to decodetree da5e5746e2 target/riscv: Convert RV64I load/store insns to decodetree 4a0c4de165 target/riscv: Convert RV32I load/store insns to decodetree 4f89876d36 target/riscv: Convert RVXI branch insns to decodetree 5bacc0d5f9 target/riscv: Activate decodetree and implemnt LUI & AUIPC === OUTPUT BEGIN === 1/34 Checking commit 5bacc0d5f955 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1884: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 1/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/34 Checking commit 4f89876d362f (target/riscv: Convert RVXI branch insns to decodetree) 3/34 Checking commit 4a0c4de1659b (target/riscv: Convert RV32I load/store insns to decodetree) 4/34 Checking commit da5e5746e24c (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 4/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/34 Checking commit 0b0675d537be (target/riscv: Convert RVXI arithmetic insns to decodetree) 6/34 Checking commit 674da1a17830 (target/riscv: Convert RVXI fence insns to decodetree) 7/34 Checking commit 29c983f8f032 (target/riscv: Convert RVXI csr insns to decodetree) 8/34 Checking commit abc495f8616a (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 169 lines checked Patch 8/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/34 Checking commit 5450d8d4886a (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 199 lines checked Patch 9/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/34 Checking commit 83d2832ed17e (target/riscv: Convert RV64A insns to decodetree) 11/34 Checking commit 8aebcb350c32 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 442 lines checked Patch 11/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 12/34 Checking commit 3b814c1bc6a7 (target/riscv: Convert RV64F insns to decodetree) 13/34 Checking commit 8b1cbcfdb000 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 398 lines checked Patch 13/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 14/34 Checking commit 111ab993394d (target/riscv: Convert RV64D insns to decodetree) 15/34 Checking commit e3a4548a0b77 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 15/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/34 Checking commit 4fd1181ee3be (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #251: FILE: target/riscv/translate.c:1072: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 231 lines checked Patch 16/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/34 Checking commit acc7f5008001 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 18/34 Checking commit 628e2ef24e5a (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 19/34 Checking commit f9156ac8451e (target/riscv: Remove gen_jalr()) 20/34 Checking commit 79ac650f56c8 (target/riscv: Remove manual decoding from gen_branch()) 21/34 Checking commit 6140efd89e23 (target/riscv: Remove manual decoding from gen_load()) 22/34 Checking commit a9c474569fcc (target/riscv: Remove manual decoding from gen_store()) 23/34 Checking commit 743385aa2611 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 24/34 Checking commit 92769a48c704 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 25/34 Checking commit 36fd7789f5ae (target/riscv: Remove shift and slt insn manual decoding) 26/34 Checking commit 8056650f79a0 (target/riscv: Remove manual decoding of RV32/64M insn) 27/34 Checking commit ab3c0b429e67 (target/riscv: Rename trans_arith to gen_arith) 28/34 Checking commit 89c15cbd76f7 (target/riscv: Remove gen_system()) 29/34 Checking commit 2589dfcbeefc (target/riscv: Remove decode_RV32_64G()) 30/34 Checking commit 25611ad897f2 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:548: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 30/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/34 Checking commit d13b40ed122f (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 32/34 Checking commit 994387064c39 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 309 lines checked Patch 32/34 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/34 Checking commit 115c117df912 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 34/34 Checking commit 13675555e5de (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190222141024.22217-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
