On 2/26/19 3:39 AM, David Hildenbrand wrote: > Combine all variant in a single handler. As source and destination > have different element sizes, we can't use gvec expansion. Expand > manually. Also watch out for overlapping source and destination and > use a temporary register in that case. > > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > target/s390x/insn-data.def | 8 +++++++ > target/s390x/translate_vx.inc.c | 41 +++++++++++++++++++++++++++++++++ > 2 files changed, 49 insertions(+)
This works as is, so Reviewed-by: Richard Henderson <richard.hender...@linaro.org> But the same comment applies wrt iteration order and not needing a temporary. High unpack can iterate backward, while low unpack can iterate forward, with no lost data. r~
