On Thu, Mar 31, 2011 at 12:38 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 31.03.2011 13:15, schrieb Jes Sorensen: >> On 03/31/11 12:38, Kevin Wolf wrote: >>> Am 30.03.2011 14:16, schrieb jes.soren...@redhat.com: >>>> From: Jes Sorensen <jes.soren...@redhat.com> >>>> >>>> This adds the basic infrastructure for supporting progress output >>>> on the command line, as well as progress support for qemu-img commands >>>> 'rebase' and 'convert'. >>>> >>>> Signed-off-by: Jes Sorensen <jes.soren...@redhat.com> >>> >>> Thanks, applied to the block branch. >>> >>> I think we should consider turning the progress output on by default if >>> qemu-img is run from a terminal. >> >> Thanks! >> >> I have been a little reluctant to do this because it will break the ABI >> for tools running qemu-img from a GUI etc. > > That's the reason for the "from a terminal" part. If we check for > isatty(), we should handle these cases just fine.
Yes, I think checking for a tty is enough precaution and allows users to get the benefit of the progress bar. TBH I'd probably forget to add -p half the time :). Stefan
