On 3/1/19 2:03 PM, Eric Blake wrote:
> On 3/1/19 1:57 PM, John Snow wrote:
>
>>>> + if ((flags & BDRV_BITMAP_BUSY) && bdrv_dirty_bitmap_busy(bitmap)) {
>>>> + error_setg(errp, "Bitmap '%s' is currently in use by another"
>>>> + " operation and cannot be used", bitmap->name);
>>>
>>> Split before space,
>>>
>
>>>> + error_setg(errp, "Bitmap '%s' is inconsistent and cannot be used",
>>>> + bitmap->name);
>>>> + error_append_hint(errp, "Try block-dirty-bitmap-remove to delete "
>>>> + "this bitmap from disk");
>>>
>>> split after space. Looks inconsistent within a single function (pardon
>>> the pun :)
>>>
>>
>> Ah... I've never known how to split strings. In fact, does anyone?
>> I'll address this either in staging or as a follow-up, as I assume
>> Vladimir will have some comments for me.
>
> I don't care which way you go. git says we have both styles with enough
> frequency that I wouldn't rule out the other style in HACKING. But it
> also says split after space seems more common, if you trust my regex:
>
Shoot, I was in the wrong directory when I counted. Trying again, this
time on qemu.git:
$ git grep '"[^"]* "$' | wc
1566 13019 135245
$ git grep '^[[:space:]]*" [^"]*"' | wc
1714 11772 130881
and now the numbers favor split before space.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
