On Tue, 5 Mar 2019 09:46:21 +0100 Thomas Huth <th...@redhat.com> wrote:
> There are some fields in our struct LowCore which apparently have > been copied from a very old version of the Linux kernel. These > fields are not architected in the "Principles of Operation", and > only used on these memory locations in Linux kernels older than > 2.6.29. Newer Linux kernels moved the entries to different locations > or are not using them at all anymore. Thus we should never access > these fields from the QEMU side, so they should be removed. > > While we're at it, also add a QEMU_BUILD_BUG_MSG() statement to s/QEMU_BUILD_BUG_MSG/QEMU_BUILD_BUG_ON/ :) (fixed up while applying) > assert that struct LowCore has the right size. > > Reviewed-by: David Hildenbrand <da...@redhat.com> > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > v3: Use QEMU_BUILD_BUG_ON instead of QEMU_BUILD_BUG_MSG > > target/s390x/internal.h | 41 ++--------------------------------------- > 1 file changed, 2 insertions(+), 39 deletions(-) Thanks, applied.