On 08/03/2019 02.32, Philippe Mathieu-Daudé wrote: > Back in abe147e0ce4 when fw_cfg_add_file() was introduced, there > was no QOM design, object where not created and released at runtime. > Later 38f3adc34d finished the QOM conversion of the fw_cfg device, > adding the fw_cfg_common_realize() method. > The time has come to add the equivalent destructor and release the > memory allocated for 'files'.
You should mention that the unrealize function is currently never called since the object never gets destroyed (AFAIK). But I hope we can fix that in the not so distant future, so: Reviewed-by: Thomas Huth <th...@redhat.com>
