On 07/03/2019 22.52, Li-Wen Hsu wrote: > On Fri, Mar 8, 2019 at 4:30 AM Thomas Huth <th...@redhat.com> wrote: >> >> On 07/03/2019 21.26, Ed Maste wrote: >>> On Mon, 4 Mar 2019 at 07:11, Philippe Mathieu-Daudé <phi...@redhat.com> >>> wrote: >>>> >>>> On 3/4/19 11:32 AM, Thomas Huth wrote: >>>>> cirrus-ci.com also has the possibility to run CI tasks on macOS. >>>>> Since most of the QEMU developers do not have access to macOS yet, >>>>> let's add a CI pipeline for this operating system here, too. >>>> >>>>> Signed-off-by: Thomas Huth <th...@redhat.com> >>>> Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> >>> Acked-by: Ed Maste <ema...@freebsd.org> >> >> Thanks! I can take this patch through my qtest tree. > > Hi Thomas, > > Sorry for the late reply, I checked and tested the patch, it works > fine. BTW, may I suggest: > > From https://cirrus-ci.org/guide/macOS/ , the image high-sierra-base > is lasted as "Not maintained", how about change to mojave-base?
Definitely! Not sure how I could have missed that... I was either blind, or, how I remember it, the high-sierra-base image was not marked as unmaintained yet and marked as the only image that had the brew system pre-installed back then. Anyway, I've now switched to mojave-base and it seems to work fine, too. > Also, perhaps we can put the common: > > env: > CIRRUS_CLONE_DEPTH: 1 > > in the global area? Sure! I'll do that in v2. Thanks for the review, Thomas