Remove is an inherently RW operation, so this will fail anyway, but we can fail it very quickly instead of trying and failing, so do so.
Signed-off-by: John Snow <js...@redhat.com> Reviewed-by: Eric Blake <ebl...@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> Message-id: 20190301191545.8728-6-js...@redhat.com Signed-off-by: John Snow <js...@redhat.com> --- blockdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/blockdev.c b/blockdev.c index c6c7a64bfc..51fcfb7faf 100644 --- a/blockdev.c +++ b/blockdev.c @@ -2882,7 +2882,8 @@ void qmp_block_dirty_bitmap_remove(const char *node, const char *name, return; } - if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_BUSY, errp)) { + if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_BUSY | BDRV_BITMAP_RO, + errp)) { return; } -- 2.17.2