I submitted a first version some days ago, which homogeneized the implementation, as suggested by Laurent Vivier. It received some feedback from Eric Blake. A patchset (v3) is ready for review: https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/#
The feature requested in this issue is included in the patchset: [Qemu-devel] [PATCH v3 6/10] qemu-binfmt-conf.sh: generalize <CPU> to positional <CPUS> https://patchew.org/QEMU/20190306031221.GA53@03612eec87fc/20190306045019.GF75@03612eec87fc/ Note that, instead of adding a parameter named `--target`, positional arguments are used, which where not being processed at all. ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1817239 Title: add '--targets' option to qemu-binfmt-conf.sh Status in QEMU: In Progress Bug description: I'd like to ask for the addition of option '--targets' to scripts /qemu-binfmt-conf.sh, in order to allow registering the interpreters for the given list of architectures only, instead of using all of the ones defined in qemu_target_list. The following is a possible patch that implements it: qemu-binfmt-conf.sh | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qemu-binfmt-conf.sh b/qemu-binfmt-conf.sh index b5a1674..be4a19b 100644 --- a/qemu-binfmt-conf.sh +++ b/qemu-binfmt-conf.sh @@ -170,6 +170,7 @@ usage() { Usage: qemu-binfmt-conf.sh [--qemu-path PATH][--debian][--systemd CPU] [--help][--credential yes|no][--exportdir PATH] [--persistent yes|no][--qemu-suffix SUFFIX] + [--targets TARGETS] Configure binfmt_misc to use qemu interpreter @@ -189,6 +190,8 @@ Usage: qemu-binfmt-conf.sh [--qemu-path PATH][--debian][--systemd CPU] --persistent: if yes, the interpreter is loaded when binfmt is configured and remains in memory. All future uses are cloned from the open file. + --targets: comma-separated list of targets. If provided, only + the targets in the list are registered. To import templates with update-binfmts, use : @@ -324,7 +327,7 @@ CREDENTIAL=no PERSISTENT=no QEMU_SUFFIX="" -options=$(getopt -o ds:Q:S:e:hc:p: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent: -- "$@") +options=$(getopt -o ds:Q:S:e:hc:p:t: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent:,targets: -- "$@") eval set -- "$options" while true ; do @@ -380,6 +383,10 @@ while true ; do shift PERSISTENT="$1" ;; + -t|--targets) + shift + qemu_target_list="$(echo "$1" | tr ',' ' ')" + ;; *) break ;; -- 2.20.1 To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1817239/+subscriptions
