On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote:
On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote:
Many PCI BARs that use the memory address space map a single MMIO region into
the entire BAR range.  Introduce an API pci_register_bar_simple() for that use
case, and convert all users where this can be done trivially.

This will reduce the work required to introduce a PCI memory API; it's also
a nice code reduction in its own right.
This will save some code, so
Acked-by: Michael S. Tsirkin<m...@redhat.com>

I really hope the rest of devices will follow.

How complete is this?

From a couple of quick greps, it looks like this covers most everything that it can.

Acked-by: Anthony Liguori <aligu...@us.ibm.com>

Regards,

Anthony Liguori

Avi Kivity (10):
   pci: add pci_register_bar_simple() API
   rtl8139: convert to pci_register_bar_simple()
   cirrus-vga: convert to pci_register_bar_simple()
   eepro100: convert to pci_register_bar_simple()
   ich/ahci: convert to pci_register_bar_simple()
   hda-intel: convert to pci_register_bar_simple()
   hda-intel: convert to pci_register_bar_simple() (partial)
   pcnet-pci: convert to pci_register_bar_simple()
   usb-ohci: convert to pci_register_bar_simple()
   wdt_i6300esb: convert to pci_register_bar_simple()

  hw/cirrus_vga.c   |   13 ++-----------
  hw/eepro100.c     |   43 +++++++++++++------------------------------
  hw/ide/ahci.c     |    9 ---------
  hw/ide/ahci.h     |    3 ---
  hw/ide/ich.c      |    3 +--
  hw/intel-hda.c    |   11 +----------
  hw/lsi53c895a.c   |   12 +-----------
  hw/pci.c          |   17 +++++++++++++++++
  hw/pci.h          |    3 +++
  hw/pcnet-pci.c    |   16 +---------------
  hw/rtl8139.c      |   11 +----------
  hw/usb-ohci.c     |   10 +---------
  hw/wdt_i6300esb.c |   42 +++++++++++++++---------------------------
  13 files changed, 56 insertions(+), 137 deletions(-)


Reply via email to