Hi Phil, On 03/11/19 01:30, Philippe Mathieu-Daudé wrote: > Hi, > > This series add a job to Travis CI to build the last EDK2 stable > release roms within QEMU. > This job is only triggered if a commit matches 'EDK2' or during > QEMU releases (when tags are pushed). > > Job output: https://travis-ci.org/philmd/qemu/jobs/504460932 > Duration: 33 min 51 sec (output 5080 lines) > > Based on Laszlo's series "bundle edk2 platform firmware with QEMU": > https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg02846.html > > Please review, > > Phil. > > Based-on: 20190309004826.9027-1-ler...@redhat.com > > Philippe Mathieu-Daudé (5): > roms/edk2: Avoid bashism in Makefile 'shell' function > roms/edk2: Avoid bashism in script > roms/edk2: Pass extra arguments to the build script via > EDK2_BUILD_OPTIONS > NOTFORMERGE roms/edk2: Use arm-linux-gnueabihf-gcc on Debian based > distribs > .travis.yml: Build and install EDK2 roms > > .travis.yml | 21 +++++++++++++++++++++ > roms/Makefile.edk2 | 8 +++++++- > roms/edk2-funcs.sh | 9 +++++++-- > 3 files changed, 35 insertions(+), 3 deletions(-) >
The first two patches are not right, in my opinion. "bash" is a valid requirement for "edk2-funcs.sh". The problem with my series was that this requirement was not spelled out. I'll fix that. Regarding the third patch. I also disagree with that (again in accordance with what I commented under the larger series). EDK2_BUILD_OPTIONS does not belong in "roms/Makefile.edk2", but (if anywhere) in "edk2-build.sh". And, I *really* don't like the ability to hook random stuff into the build command line. If we have a specific use case (and we do: "--log"), then we should address that, in "edk2-build.sh". Thanks Laszlo
