Hi Daniel, On 3/15/19 12:28 PM, Daniel P. Berrangé wrote: > On Thu, Mar 14, 2019 at 07:43:58PM +0100, Philippe Mathieu-Daudé wrote: >> On 3/13/19 10:00 PM, Laszlo Ersek wrote: >>> Add the files built by the last patch: (compressed) binaries, and the >>> cumulative license text that covers them. >>> >>> Signed-off-by: Laszlo Ersek <ler...@redhat.com> >>> --- >>> >>> Notes: >>> v2: >>> >>> - capture the compressed build outputs of the last patch; slightly >>> update the commit message [Dan, Michael, Phil] >>> >>> - consequently, do not pick up Michal's and Michael's R-b's >> >> Well I was not explicit in my previous review: I simply checked the >> Licenses match the EDK2 project, but I haven't review the binaries. >> Ideally I'd rather submit the binaries from a CI system or a Docker >> image than your workstation. > > I think that point probably applies to all of the binary ROMs > that QEMU is already distributing. > > We have make rules that build them from the subdir, but we have > no record of what kind of host they were built on by the maintainer > which is troublesome for reproducability. > > It would be nice if we had a standard dockerfile that was designated > as the build environment for each of the ROMs (one docker file might > be suitable for many of the ROMs in fact).
Actually I use docker to build EDK2: https://github.com/philmd/edk2-docker/tree/aarch64_builds
