On Fri, 15 Mar 2019 at 09:37, Chen Zhang <tgfb...@me.com> wrote:
>
> Signed-off-by: Chen Zhang <tgfb...@me.com>
Again, it would be nice to see a commit message here
that explained what was being changed and why.
If you take my suggestion from my review of patch 1 this is
no longer relevant, but:
> @@ -881,7 +900,7 @@ QemuCocoaView *cocoaView;
> break;
> case NSEventTypeLeftMouseUp:
> mouse_event = true;
> - if (!isMouseGrabbed && [self screenContainsPoint:p]) {
> + if (!isMouseGrabbed && [self screenContainsPointOfEvent:event]) {
> if([[self window] isKeyWindow]) {
> [self grabMouse];
> }
> @@ -944,7 +963,7 @@ QemuCocoaView *cocoaView;
> if (isMouseGrabbed) {
> if (isAbsoluteEnabled) {
> /* Note that the origin for Cocoa mouse coords is bottom
> left, not top left.
> - * The check on screenContainsPoint is to avoid sending out
> of range values for
> + * The check on screenContainsPointOfEvent is to avoid
> sending out of range values for
> * clicks in the titlebar.
> */
> if ([self screenContainsPointOfEvent:event]) {
> --
> 2.19.2
These two changes really belong in patch 1, not patch 2, don't they?
thanks
-- PMM
