Hi Igor, > -----Original Message----- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: 18 March 2019 12:26 > To: Shameerali Kolothum Thodi <shameerali.kolothum.th...@huawei.com> > Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; > eric.au...@redhat.com; peter.mayd...@linaro.org; > shannon.zha...@gmail.com; sa...@linux.intel.com; > sebastien.bo...@intel.com; Linuxarm <linux...@huawei.com>; xuwei (O) > <xuw...@huawei.com> > Subject: Re: [PATCH v2 09/11] hw/acpi: Add ACPI Generic Event Device Support > > On Fri, 8 Mar 2019 11:42:16 +0000 > Shameer Kolothum <shameerali.kolothum.th...@huawei.com> wrote: > > > From: Samuel Ortiz <sa...@linux.intel.com> > > > > The ACPI Generic Event Device (GED) is a hardware-reduced specific > > device that handles all platform events, including the hotplug ones. > > This patch generate the AML code that defines GEDs. > > Platforms need to specify their own GedEvent array to describe what kind > > of events they want to support through GED. The build_ged_aml routine > > takes a GedEvent array that maps a specific GED event to an IRQ number. > > Then we use that array to build both the _CRS and the _EVT section > > of the GED device. > > I'd this a part of "virtual ACPI device"
Just to confirm, you meant, instead of separate virt-acpi.c and ged.c, move the contents of this patch into "virtual ACPI device" implementation (something like hw/acpi/generic-event-device.c) ? Please let me know. Thanks, Shameer > > This is in preparation for making use of GED for ARM/virt > > platform and for now supports only memory hotplug. > > > > Signed-off-by: Samuel Ortiz <sa...@linux.intel.com> > > Signed-off-by: Sebastien Boeuf <sebastien.bo...@intel.com> > > Signed-off-by: Shameer Kolothum <shameerali.kolothum.th...@huawei.com> > > --- > [...]
