On Thu, Mar 07, 2019 at 04:58:24PM +0000, Daniel P. Berrangé wrote: > We were never reporting the G_IO_HUP event when an end of file was hit > on the websocket channel. > > We also didn't report G_IO_ERR when we hit a fatal error processing the > websocket protocol. > > The latter in particular meant that the chardev code would not notice > when an eof/error was encountered on the websocket channel, unless the > guest OS happened to trigger a write operation. > > This meant that once the first client had quit, the chardev would never > listen to accept a new client. > > Fixes launchpad bug 1816819 > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > --- > > Changed in v2: > - Fix typo > - Remove use of G_IO_IN at same time as HUP/ERR since. It is > not required since the websock source doesn't do a real > poll itself. > > io/channel-websock.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-)
The patch LGTM. Acked-by: Stefano Garzarella <sgarz...@redhat.com> Thanks, Stefano
