On Mon, Mar 25, 2019 at 01:10:46PM +0100, Kevin Wolf wrote: > Am 22.03.2019 um 18:52 hat Daniel Henrique Barboza geschrieben: > > Adding to Block Drivers the capability of being able to clean up > > its created files can be useful in certain situations. For the > > LUKS driver, for instance, a failure in one of its authentication > > steps can leave files in the host that weren't there before. > > > > This patch adds the 'bdrv_co_delete_file' interface to block > > drivers and add it to the LUKS driver. The implementation is provided > > in a new 'bdrv_co_delete_file_generic' function inside block.c. This > > function is made public in case other block drivers wants to > > support this cleanup interface as well. > > > > Suggested-by: Daniel P. Berrangé <berra...@redhat.com> > > Signed-off-by: Daniel Henrique Barboza <danielhb...@gmail.com> > > This is still wrong. Consider a LUKS image that is accessed via http:// > rather than in a local file. > > Instead of the "generic" implementation in block.c (which isn't actually > generic, but very specific to local files), this needs to be the > implementation for the file driver in block/file-posix.c. > > The call of bdrv_co_delete_file() must then be in the error path of the > same function that called bdrv_create_file(), such as > block_crypto_co_create_opts_luks() in your specific example.
I thought it was previously suggested that we did *not* want to put the calls in that kind of place, as it would lead us to delete files that the user had pre-created ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
