Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com> writes:
> There are no harm but just looks weird to return bool in
> pointer-returning function. Introduced in 69240fe62d1 with the whole
> failure-checking "if" chunk.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
> ---
> qapi/qmp-dispatch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
> index 5f812bb9f2..e2c366e09e 100644
> --- a/qapi/qmp-dispatch.c
> +++ b/qapi/qmp-dispatch.c
> @@ -111,7 +111,7 @@ static QObject *do_qmp_dispatch(QmpCommandList *cmds,
> QObject *request,
> if (oob && !(cmd->options & QCO_ALLOW_OOB)) {
> error_setg(errp, "The command %s does not support OOB",
> command);
> - return false;
> + return NULL;
> }
>
> if (runstate_check(RUN_STATE_PRECONFIG) &&
Pasto. Messed up in commit 69240fe62d1 by yours truly.
Reviewed-by: Markus Armbruster <arm...@redhat.com>
and queued. Thanks!
