On Fri, 29 Mar 2019 at 13:13, Stefano Garzarella <sgarz...@redhat.com> wrote: > > On Thu, Mar 28, 2019 at 03:26:35PM +0000, Peter Maydell wrote: > > In the stripe8() function we use a variable length array; however > > we know that the maximum length required is MAX_NUM_BUSSES. Use > > a fixed-length array and an assert instead. > > > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > > --- > > hw/ssi/xilinx_spips.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > I really think is a good idea to remove variable length arrays! > > Reviewed-by: Stefano Garzarella <sgarz...@redhat.com>
Yeah; we have some but not a vast number, so I thought I'd whittle down a few easy candidates. Feel free to have a look at some yourself :-) thanks -- PMM
