On Wed, Mar 27, 2019 at 08:24:21PM +0000, Dr. David Alan Gilbert wrote: >* Wei Yang (richardw.y...@linux.intel.com) wrote: >> MigrationState->xfer_limit is only set to 0 in migrate_init(). >> >> Remove this unnecessary field. >> >> Signed-off-by: Wei Yang <richardw.y...@linux.intel.com> > >Nice; I think that field has been unneeded since 1964a397063967 >just over 5 years ago :-) >
Hi, David, I found xfer_limit has an orphan brother, bytes_xfer. Do you want me to send a separate patch or spin v2 to adopt these two together? > >Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > >> --- >> migration/migration.c | 1 - >> migration/migration.h | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/migration/migration.c b/migration/migration.c >> index e88acab53b..533c2102c7 100644 >> --- a/migration/migration.c >> +++ b/migration/migration.c >> @@ -1682,7 +1682,6 @@ void migrate_init(MigrationState *s) >> * locks. >> */ >> s->bytes_xfer = 0; >> - s->xfer_limit = 0; >> s->cleanup_bh = 0; >> s->to_dst_file = NULL; >> s->rp_state.from_dst_file = NULL; >> diff --git a/migration/migration.h b/migration/migration.h >> index 99e99e56bd..852eb3c4e9 100644 >> --- a/migration/migration.h >> +++ b/migration/migration.h >> @@ -117,7 +117,6 @@ struct MigrationState >> >> /*< public >*/ >> size_t bytes_xfer; >> - size_t xfer_limit; >> QemuThread thread; >> QEMUBH *cleanup_bh; >> QEMUFile *to_dst_file; >> -- >> 2.19.1 >> >-- >Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK -- Wei Yang Help you, Help me
