On 4/2/19 10:15 PM, Mateja Marjanovic wrote: > +static inline void gen_ilvod_w(CPUMIPSState *env, uint32_t wd, > + uint32_t ws, uint32_t wt) > +{ > + TCGv_i64 t1 = tcg_temp_new_i64(); > + const uint64_t mask = 0xffffffff00000000ULL; > + > + tcg_gen_andi_i64(t1, msa_wr_d[wt * 2], mask); > + tcg_gen_shri_i64(t1, t1, 32);
The andi is useless. The bits that it discards are also discarded by the shift. r~