While global_qtest and its wrapper functions work fine for tests that only run one instance of QEMU, using the global_qtest variable in our qtests is very problematic for tests that use multiple test states (e.g. migration tests). Thus tests that still use global_qtest make it hard to share code (either by copy-n-pasting or by calling common functions) with tests that try to track multiple test states, so we should try to completely get rid of the global_qtest variable and its wrapper function in the long run.
Here's another set of patches that cleans up the usage of global_qtest in a couple of tests. Thomas Huth (5): tests/tco: Make test independent of global_qtest tests/megasas: Make test independent of global_qtest tests/qmp-cmd-test: Use qtest_init() instead of qtest_start() tests/test-hmp: Use qtest_init() instead of qtest_start() tests/ide-test: Make test independent of global_qtest tests/ide-test.c | 284 ++++++++++++++++++++++++------------------- tests/megasas-test.c | 2 +- tests/qmp-cmd-test.c | 15 ++- tests/tco-test.c | 63 +++++----- tests/test-hmp.c | 19 +-- 5 files changed, 211 insertions(+), 172 deletions(-) -- 2.21.0
