Patchew URL: https://patchew.org/QEMU/20190417191805.28198-1-arm...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190417191805.28198-1-arm...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/17] Clean up and simplify around fprintf_function Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190417191805.28198-1-arm...@redhat.com -> patchew/20190417191805.28198-1-arm...@redhat.com Switched to a new branch 'test' 8b142fc767 include: Move fprintf_function to disas/ d69f01b1b3 disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h 473a1c8779 monitor: Clean up how monitor_disas() funnels output to monitor 363a8f9258 qom/cpu: Simplify how CPUClass:cpu_dump_state() prints a2be3c05f9 qemu-print: New qemu_fprintf(), qemu_vfprintf() 1f6386c655 qom/cpu: Simplify how CPUClass::dump_statistics() prints fc33835b61 target/i386: Simplify how x86_cpu_dump_local_apic_state() prints bea3b777db target: Clean up how the dump_mmu() print 0cf22bb8f4 target: Simplify how the TARGET_cpu_list() print edae5f9c36 memory: Clean up how mtree_info() prints 409b0a9ef6 block/qapi: Clean up how we print to monitor or stdout a2db2c108d qsp: Simplify how qsp_report() prints eeef382c8b tcg: Simplify how dump_drift_info() prints 26f0941f15 tcg: Simplify how dump_exec_info() prints 1befd4787a tcg: Simplify how dump_opcount_info() prints ca597f2d8e trace: Simplify how st_print_trace_file_status() prints 1c6d436697 include: Include fprintf-fn.h only where needed === OUTPUT BEGIN === 1/17 Checking commit 1c6d43669789 (include: Include fprintf-fn.h only where needed) 2/17 Checking commit ca597f2d8e95 (trace: Simplify how st_print_trace_file_status() prints) 3/17 Checking commit 1befd4787a61 (tcg: Simplify how dump_opcount_info() prints) 4/17 Checking commit 26f0941f15dc (tcg: Simplify how dump_exec_info() prints) 5/17 Checking commit eeef382c8bdb (tcg: Simplify how dump_drift_info() prints) 6/17 Checking commit a2db2c108d25 (qsp: Simplify how qsp_report() prints) 7/17 Checking commit 409b0a9ef641 (block/qapi: Clean up how we print to monitor or stdout) 8/17 Checking commit edae5f9c360a (memory: Clean up how mtree_info() prints) 9/17 Checking commit 0cf22bb8f42e (target: Simplify how the TARGET_cpu_list() print) 10/17 Checking commit bea3b777dbfa (target: Clean up how the dump_mmu() print) WARNING: line over 80 characters #950: FILE: target/xtensa/mmu_helper.c:784: + qemu_printf("\tVaddr Paddr ASID Attr RWX Cache\n" total: 0 errors, 1 warnings, 848 lines checked Patch 10/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/17 Checking commit fc33835b6178 (target/i386: Simplify how x86_cpu_dump_local_apic_state() prints) 12/17 Checking commit 1f6386c655a5 (qom/cpu: Simplify how CPUClass::dump_statistics() prints) 13/17 Checking commit a2be3c05f9fc (qemu-print: New qemu_fprintf(), qemu_vfprintf()) 14/17 Checking commit 363a8f9258a4 (qom/cpu: Simplify how CPUClass:cpu_dump_state() prints) ERROR: line over 90 characters #1051: FILE: target/i386/helper.c:419: + qemu_fprintf(f, "RAX=%016" PRIx64 " RBX=%016" PRIx64 " RCX=%016" PRIx64 " RDX=%016" PRIx64 "\n" ERROR: line over 90 characters #1052: FILE: target/i386/helper.c:420: + "RSI=%016" PRIx64 " RDI=%016" PRIx64 " RBP=%016" PRIx64 " RSP=%016" PRIx64 "\n" ERROR: line over 90 characters #1053: FILE: target/i386/helper.c:421: + "R8 =%016" PRIx64 " R9 =%016" PRIx64 " R10=%016" PRIx64 " R11=%016" PRIx64 "\n" ERROR: line over 90 characters #1054: FILE: target/i386/helper.c:422: + "R12=%016" PRIx64 " R13=%016" PRIx64 " R14=%016" PRIx64 " R15=%016" PRIx64 "\n" ERROR: line over 90 characters #1055: FILE: target/i386/helper.c:423: + "RIP=%016" PRIx64 " RFL=%08x [%c%c%c%c%c%c%c] CPL=%d II=%d A20=%d SMM=%d HLT=%d\n", WARNING: line over 80 characters #1163: FILE: target/i386/helper.c:494: + qemu_fprintf(f, "CR0=%08x CR2=%016" PRIx64 " CR3=%016" PRIx64 " CR4=%08x\n", WARNING: line over 80 characters #1751: FILE: target/mips/translate.c:29791: + qemu_fprintf(f, "CP0 Status 0x%08x Cause 0x%08x EPC 0x" TARGET_FMT_lx "\n", total: 5 errors, 2 warnings, 2551 lines checked Patch 14/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/17 Checking commit 473a1c877930 (monitor: Clean up how monitor_disas() funnels output to monitor) 16/17 Checking commit d69f01b1b315 (disas: Rename include/disas/bfd.h back to include/disas/dis-asm.h) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #296: rename from include/disas/bfd.h total: 0 errors, 1 warnings, 192 lines checked Patch 16/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/17 Checking commit 8b142fc76760 (include: Move fprintf_function to disas/) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #45: deleted file mode 100644 total: 0 errors, 1 warnings, 17 lines checked Patch 17/17 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190417191805.28198-1-arm...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
